Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

I wouldn't review it - bad engineering practice to submit this much work in one go - it puts too much expectation on the reviewer and makes it more likely that something gets broken.

Even 1000 lines is pushing it, IMO. Tell them to split the PR up into more granular work if they want it merged.



Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: