Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Some Amazon programmer tomorrow

priceIncrease := (newPrice - oldPrice) / oldPrice var trump_tariff bool

if priceIncrease > 1.0 { trump_tariff = true }



Please don't use if:s to assign boolean literals, just do it:

    const trump_tariff = priceIncrease > 1.0
also saves you from not initializing the variable in the default/other case. :)


This was just someone showing you what the "Amazon programmer" was doing, and hence a deep cut reference to the likelihood of it being poor quality code :)


If you really wanted to look like Amazon codex you would write Java :)


I see I missed an opportunity to make it even funnier.


    const
I feel you may underestimate how often they change.


not to mention the mix of snake_case & camelCase


In the original code, trump_tariff is a sticky value. If that’s intended/not intended, the above introduces/fixes a bug.


If statements are great because they are highly readable.




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: