Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

Definitely don't check that a variable is non-empty before running

    rm -rf ${VAR}/*
That's typically a great experience for shell scripts!



Also, you'd want to put in a double dash to signify the end of arguments as otherwise someone could set VAR="--no-preserve-root " and truly trash the system. Also, ${VAR} needs to be in double quotes for something as dangerous as a "rm" command:

    rm -rf -- "${VAR}"/*




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: