Hacker Newsnew | past | comments | ask | show | jobs | submitlogin

This is bizarre over engineering:

https://github.com/goldmansachs/gs-quant/blob/51a7ff1afb722c...



What about the @plot_function bit? Also, wrapping dependency calls for a more consistent interface isn’t necessarily a bad thing.


Does someone have LOC as a performance indicator?


Unironically probably. The only place I've ever worked that used LoC as a performance indicator was a hedge fund.


It’s so bizarre my first reaction was that surely it must be so an LLM can make some kind of sense of it, otherwise what on earth are they doing?


The pointless act of "encapsulating" nothing? I see that a lot unfortunately =[


Presumably @plot_function does something. Also there are lots of other functions in the same API that are more than one line.

I suspect he wouldn't have thought it was over engineering if it didn't have such a long comment for one line of code... Which is silly.


[flagged]


I’m a trader


Surely you've worked with other traders who get confused by import statements. Whole point of this file is to provide a common interface for common math operations that might be exposed by either plain python or pandas/numpy functions.

You're obviously not the target market if you're able to review good and bad code.


That was unnecessarily mean. What did you mean?




Guidelines | FAQ | Lists | API | Security | Legal | Apply to YC | Contact

Search: